The character arc wasn't finished but we got that end result in Justice League when Clark was revived. We saw glimpses of it in MOS and BvS but he was still learning the ropes on what a hero is(he has only been Superman for like a year or so) as well as juggling it with his civilian life. Like I mentioned before, this characterization is akin to Byrne's Superman. To quote John Byrne on his interpretation of the character
Batman, his kills were less direct than what we saw in Batman 89, Batman Returns, and pre-Robin golden age

. He was older, and lost his way a bit. Him realizing Superman was a man with loved ones and not some monster brought him back
These characters been around since the 1930s with thousands of stories written by tons of different writers each with their own interpretation of the character.
You can not like how they are shown but to say the characterizations are wrong is false, imo